Conversation
src/avlizer_confluent.erl
Outdated
| download(Ref) -> | ||
| gen_server:call(?SERVER, {download, Ref}, infinity). | ||
|
|
||
| %% Download schema from registry and insert into cache. |
|
Hi, thanks for the PR! And apologies for slow responses. I have only one small comment, everything looks good otherwise. |
| %% bytes overhead), but relies on the registry. | ||
| %% | ||
| %% The fingerprint is more static, and can be obtained at compile | ||
| %% time, but it is harder to share with other applications and evolve |
There was a problem hiding this comment.
To share schema by fp, it is not harder than registration ID. Since they are essentially just two numbers.
One may argue that without fp as a part of the encoded payload makes it harder to share (maybe that’s what you meant)
But I would phrase it as more freedom on choosing means to share.
There was a problem hiding this comment.
E.g fp as payload meta data (it’s common to have envelops )
Or fp in kafka message header. Etc.
Even we in some cases did double registration: the id returned from fp registration can also be used to share the schema.
|
|
4 participants
Improve documentation / comments. No code changes.